add Memory::ResetUserDict() for librime-lua release user_dict before sync data#901
Open
shewer wants to merge 35 commits intorime:masterfrom
Open
add Memory::ResetUserDict() for librime-lua release user_dict before sync data#901shewer wants to merge 35 commits intorime:masterfrom
shewer wants to merge 35 commits intorime:masterfrom
Conversation
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
713ab6f to
32cc1d9
Compare
ksqsf
reviewed
Jun 20, 2024
Member
ksqsf
left a comment
There was a problem hiding this comment.
- API 名不應該叫
Reset,聽起來像是重新初始化用戶詞典。叫Release吧。 - 這個 API 似乎比較容易誤用。雖然看起來不會導致崩潰,但是會導致 Reset 之後 user_dict_ 再也不會回來。
Memory 析構後自然會釋放 user_dict,所以我覺得不應該通過增加一個容易誤用的 API ad hoc 地解決問題。
Contributor
Author
Signed-off-by: shewer <shewer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull request
改善 librime-lua中使用 Memory 類別時,sync user_data 異常
須要手動釋放 user_dict
hchunhui/librime-lua#335
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info