fix: leaderboard columns going stale when context is shown for all measures - #9807
Open
nishantmonu51 wants to merge 1 commit into
Open
fix: leaderboard columns going stale when context is shown for all measures#9807nishantmonu51 wants to merge 1 commit into
nishantmonu51 wants to merge 1 commit into
Conversation
…asures The colgroup, header and rows each decided which context columns to render by calling a locally declared shouldShowContextColumns(). In Svelte 5 legacy mode such a call only re-evaluates when the identifiers in the expression change, so the prop it reads is never tracked and the block goes stale until the component is remounted. Toggling "show context for all measures" therefore updated the rows (they remount when the query refetches) but not the colgroup or the header: the body rendered delta columns the table never declared, measure labels slid onto the previous measure's delta columns, and the surplus cells collapsed into overlapping text at the right edge. Derive the set of measures with context reactively in Leaderboard.svelte and pass it to the header and rows, so all three stay in sync. Along the way, fix columnCount, which counted percent-of-total from the sort measure only, and tableWidth, which only ever counted a single measure's columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
colgroup, header and rows each called a locally declaredshouldShowContextColumns()to decide which context columns to render. In Svelte 5 legacy mode that call only re-evaluates when the identifiers in the expression change, so the prop it reads is never tracked and the block goes stale until the component is remounted.colgroupor the header: the body rendered delta columns the table never declared, measure labels slid onto the previous measure's delta columns, and the surplus cells collapsed into overlapping text at the right edge. A page reload rendered it correctly, which is why it only showed up after toggling.Leaderboard.sveltenow derivesmeasuresWithContextreactively and passes it toLeaderboardHeaderandLeaderboardRow, so all three stay in sync.columnCount, which counted percent-of-total from the sort measure only, andtableWidth, which only ever counted a single measure's columns.LeaderboardHeader.spec.ts, which fails against the old function-based header (one delta column instead of two) and passes now.Checklist: