Skip to content

Discourage use of unredacted summary file #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omertuc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Discourage use of unredacted summary file #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ prost-build = "0.12.1"

[features]
generate = []
insecure_dev_only_unredacted_summary = []

# See https://github.com/coreos/cargo-vendor-filterer
[package.metadata.vendor-filter]
Expand Down
13 changes: 11 additions & 2 deletions src/logging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,18 @@ pub(crate) fn generate_summary(
error: error.map(|e| format!("{:?}", e)),
};

#[cfg(not(feature = "insecure_dev_only_unredacted_summary"))]
if summary.recert_config.summary_file.is_some() {
bail!("summary_file contains unredacted secret keys - use summary_file_clean instead, or build with --features insecure_dev_only_unredacted_summary");
}

#[cfg(feature = "insecure_dev_only_unredacted_summary")]
if let Some(summary_file) = summary.recert_config.summary_file.clone() {
let summary_file = summary_file.0.create().context("opening summary file for writing")?;
serde_yaml::to_writer(summary_file, &summary).context("serializing cluster crypto into summary file")?;
use std::os::unix::fs::PermissionsExt;
let path = summary_file.0.path().to_owned();
let file = summary_file.0.create().context("opening summary file for writing")?;
std::fs::set_permissions(&path, std::fs::Permissions::from_mode(0o600)).context("setting summary file permissions to 0600")?;
serde_yaml::to_writer(file, &summary).context("serializing cluster crypto into summary file")?;
}

if let Some(summary_file_clean) = summary.recert_config.summary_file_clean.clone() {
Expand Down
Loading