Install defaults YAML files under enclave/ package in wheel#514
Conversation
|
Warning Review limit reached
More reviews will be available in 58 minutes and 53 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe ChangesDefaults Path Resolution and Wheel Packaging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/enclave/reconcile/cli.py`:
- Around line 15-22: The defaults_path function concatenates the filename
parameter directly into a filesystem path without validation, which could allow
path traversal attacks if the function is called with untrusted input in the
future. Add a validation check at the beginning of the defaults_path function
that rejects any filename containing forward slashes (/), backslashes (\), or
double dots (..) by raising a ValueError with a descriptive error message. This
defensive measure should occur before the path is constructed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b253dc16-b303-4d25-b224-3f5fe32a6a1a
📒 Files selected for processing (2)
pyproject.tomlsrc/enclave/reconcile/cli.py
Map defaults/operators.yaml and defaults/platforms.yaml to enclave/defaults/ via hatchling wheel source mapping, so they install under the enclave package tree instead of at the site-packages root. Update defaults_path() accordingly: walk two levels up to the enclave package directory (instead of three) and fall back to repo_root/defaults/ for editable installs. Signed-off-by: Rafa Porres Molina <rporresm@redhat.com> Assisted-by: Claude Code <noreply@anthropic.com>
3401db7 to
e2db2b8
Compare
Map defaults/operators.yaml and defaults/platforms.yaml to enclave/defaults/ via hatchling wheel source mapping, so they install under the enclave package tree instead of at the site-packages root.
Update defaults_path() accordingly: walk two levels up to the enclave package directory (instead of three) and fall back to repo_root/defaults/ for editable installs.
Summary by CodeRabbit