Skip to content

OSAC-1427: Add Netris config passthrough to OSAC plugin#500

Open
eliorerz wants to merge 1 commit into
mainfrom
feature/osac-netris-config
Open

OSAC-1427: Add Netris config passthrough to OSAC plugin#500
eliorerz wants to merge 1 commit into
mainfrom
feature/osac-netris-config

Conversation

@eliorerz

Copy link
Copy Markdown
Collaborator

Summary

  • Add clusterFulfillment and networkFulfillment sections to the OSAC Helm values template, conditionally rendered when osacNetrisEnabled: true
  • Add 26 Netris-related fields to the plugin config schema with conditional if/then validation requiring core fields when enabled
  • Add commented-out example config and osacNetrisEnabled: false default

Test plan

  • make -f Makefile.ci validate-plugins passes
  • make -f Makefile.ci validate-yaml passes
  • make -f Makefile.ci validate-ansible passes
  • Manual: render values template with Netris vars set, verify fulfillment sections appear
  • Manual: render without osacNetrisEnabled, verify fulfillment sections are absent

Pass clusterFulfillment and networkFulfillment Helm values to the OSAC
chart when osacNetrisEnabled is true, allowing Netris network backend
credentials and config to flow through without deploying Netris itself.
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@eliorerz, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 37a06fb5-9e4c-41e0-a942-e62144dcc383

📥 Commits

Reviewing files that changed from the base of the PR and between 72d6071 and 6bbd2a3.

📒 Files selected for processing (4)
  • config/plugins/osac.example.yaml
  • plugins/osac/defaults.yaml
  • plugins/osac/schemas/config.yaml
  • plugins/osac/templates/values.yaml.j2
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/osac-netris-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added deployment Deployment-related changes plugins labels Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Deployment-related changes plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant