Skip to content

Add connected_auto property for operators to enable automatic approval when not disconnected#471

Open
maorfr wants to merge 1 commit into
mainfrom
feature/operator-connected-auto-approval
Open

Add connected_auto property for operators to enable automatic approval when not disconnected#471
maorfr wants to merge 1 commit into
mainfrom
feature/operator-connected-auto-approval

Conversation

@maorfr

@maorfr maorfr commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

This change introduces a new connected_auto property for operators that enables automatic install plan approval when the environment is not disconnected.

Changes

  • Added connected_auto: true to multicluster-engine operator in defaults/operators.yaml
  • Updated schemas/operators.yaml to include the new boolean property with validation
  • Modified playbooks/tasks/configure_operator.yaml to:
    • Extract approval logic to _use_automatic_approval variable
    • Use Automatic approval when operator has connected_auto: true and not disconnected
    • Maintain Manual approval for all other cases

How it works

  • When disconnected: false and operator has connected_auto: true, the operator subscription uses installPlanApproval: Automatic
  • Otherwise, operators in custom namespaces use installPlanApproval: Manual (existing behavior)
  • Operators in openshift-operators namespace always use Automatic (existing behavior)

Extensibility

This approach is extensible - any operator can set connected_auto: true in the future to get automatic approval when connected, while maintaining the current Manual behavior in disconnected environments.

Note

This is a workaround proposal to replace PR #467. We should pursue a bug with the ACM team for a proper fix, but this provides a flexible solution in the meantime.

🤖 Generated with Claude Code

…l when not disconnected

This change introduces a new `connected_auto` property for operators that
enables automatic install plan approval when the environment is not disconnected.

Changes:
- Added `connected_auto: true` to multicluster-engine operator in defaults/operators.yaml
- Updated schemas/operators.yaml to include the new boolean property with validation
- Modified playbooks/tasks/configure_operator.yaml to:
  - Extract approval logic to `_use_automatic_approval` variable
  - Use Automatic approval when operator has `connected_auto: true` and not disconnected
  - Maintain Manual approval for all other cases

This approach is extensible - any operator can set `connected_auto: true` to get
automatic approval when connected, while maintaining the current Manual behavior
in disconnected environments.

Note: This is a workaround proposal to replace PR #467. We should pursue a bug
with the ACM team for a proper fix, but this provides a flexible solution in the
meantime.

Assisted-by: Claude Code <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@maorfr, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 8 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6a7a0f97-0bec-4c27-9cf6-2df9fbdb14ce

📥 Commits

Reviewing files that changed from the base of the PR and between 91f6d95 and 615bd1f.

📒 Files selected for processing (3)
  • defaults/operators.yaml
  • playbooks/tasks/configure_operator.yaml
  • schemas/operators.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/operator-connected-auto-approval

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added deployment Deployment-related changes infrastructure Infrastructure setup (VMs, networks) validation Validation and testing operators Operator installation/config labels Jun 10, 2026
@maorfr maorfr added the rc-ok label to indicate a PR is ok to arrive to main branch while preparing a release candidate label Jun 10, 2026
@maorfr maorfr removed the rc-ok label to indicate a PR is ok to arrive to main branch while preparing a release candidate label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Deployment-related changes infrastructure Infrastructure setup (VMs, networks) operators Operator installation/config validation Validation and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant