Add connected_auto property for operators to enable automatic approval when not disconnected#471
Add connected_auto property for operators to enable automatic approval when not disconnected#471maorfr wants to merge 1 commit into
Conversation
…l when not disconnected This change introduces a new `connected_auto` property for operators that enables automatic install plan approval when the environment is not disconnected. Changes: - Added `connected_auto: true` to multicluster-engine operator in defaults/operators.yaml - Updated schemas/operators.yaml to include the new boolean property with validation - Modified playbooks/tasks/configure_operator.yaml to: - Extract approval logic to `_use_automatic_approval` variable - Use Automatic approval when operator has `connected_auto: true` and not disconnected - Maintain Manual approval for all other cases This approach is extensible - any operator can set `connected_auto: true` to get automatic approval when connected, while maintaining the current Manual behavior in disconnected environments. Note: This is a workaround proposal to replace PR #467. We should pursue a bug with the ACM team for a proper fix, but this provides a flexible solution in the meantime. Assisted-by: Claude Code <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 15 minutes and 8 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This change introduces a new
connected_autoproperty for operators that enables automatic install plan approval when the environment is not disconnected.Changes
connected_auto: trueto multicluster-engine operator indefaults/operators.yamlschemas/operators.yamlto include the new boolean property with validationplaybooks/tasks/configure_operator.yamlto:_use_automatic_approvalvariableconnected_auto: trueand not disconnectedHow it works
disconnected: falseand operator hasconnected_auto: true, the operator subscription usesinstallPlanApproval: AutomaticinstallPlanApproval: Manual(existing behavior)openshift-operatorsnamespace always useAutomatic(existing behavior)Extensibility
This approach is extensible - any operator can set
connected_auto: truein the future to get automatic approval when connected, while maintaining the current Manual behavior in disconnected environments.Note
This is a workaround proposal to replace PR #467. We should pursue a bug with the ACM team for a proper fix, but this provides a flexible solution in the meantime.
🤖 Generated with Claude Code