[WIP] Strict indentantion requirement#462
Open
rporres wants to merge 1 commit into
Open
Conversation
rporres
changed the title
github-actions
Bot
added
deployment
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (27)
WalkthroughEnforces stricter YAML formatting by removing a lenient yamllint indentation rule, adds fixture paths to yamllint ignore, tightens multiple JSON-schema required lists, and normalizes YAML indentation across operator tasks, plugins, and test fixtures. ChangesYAML Schema Validation & Indentation Standardization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 9 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.yamllint.yml:
- Line 59: The ignore glob "src/tests/fixtures/*/*.yaml" in .yamllint.yml does
not match the actual fixture paths (e.g., test-fixtures/...), so linting still
runs against those files; update the ignore entry by replacing the existing glob
"src/tests/fixtures/*/*.yaml" with a glob that matches the real fixture
directory structure (for example, use a pattern covering "test-fixtures" and
nested subfolders) so fixture YAMLs are properly excluded from yamllint.
In `@playbooks/tasks/configure_operator.yaml`:
- Around line 138-139: The readiness conditions currently index
r_subscription.resources[0] directly which will raise an error if resources is
empty; update each check (the occurrences referencing
r_subscription.resources[0].status.installplan) to first assert
r_subscription.resources is defined and has length > 0, then inspect
resources[0].status.installplan—e.g. change the when/tests to combine a guard
like r_subscription.resources | length > 0 with the subsequent checks (or use a
safe default/filter) so the installplan checks only run when resources[0]
exists; apply the same guarded pattern to the other occurrences reported (the
checks around lines 174-175 and 190-192).
In `@plugins/vast-csi/tasks/quay.yaml`:
- Around line 112-113: Replace the ansible.builtin.shell task that runs "{{
workingDir }}/bin/oc patch ..." with ansible.builtin.command using argv so the
command and each argument are passed without shell evaluation; specifically
update the task that currently uses ansible.builtin.shell to call oc (the binary
referenced as {{ workingDir }}/bin/oc) and provide each token as a separate argv
element including 'patch', 'deployment', 'registry-quay-app', '-n',
'quay-enterprise', '--type=json' and the '-p' value using the templated '{{
quay_vast_patch | to_json }}' string as a single argv entry, ensuring no shell
piping or interpolation is used and retaining the same arguments and behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d7568324-befe-4b22-89dc-341a00f75ac7
📒 Files selected for processing (27)
.yamllint.ymldefaults/platforms.yamloperators/advanced-cluster-management/tasks.yamloperators/cincinnati-operator/tasks.yamloperators/multicluster-engine/tasks.yamlplaybooks/tasks/configure_operator.yamlplugins/lvms/tasks/quay.yamlplugins/nvidia-gpu/files/20-placementrule.yamlplugins/nvidia-gpu/files/30-placementbinding.yamlplugins/odf/tasks/quay.yamlplugins/openshift-ai/files/20-placementrule.yamlplugins/openshift-ai/files/30-placementbinding.yamlplugins/vast-csi/tasks/quay.yamlschemas/catalogs.yamlschemas/control_binaries.yamlschemas/definitions.yamlschemas/operators.yamlschemas/platforms.yamlschemas/plugin.yamltest-fixtures/schemas/global/invalid/duplicated-network-config.yamltest-fixtures/schemas/global/invalid/extra-ipAddress-while-NMState.yamltest-fixtures/schemas/global/invalid/extra-macAddress-while-NMState.yamltest-fixtures/schemas/global/invalid/extra-networkConfig-while-no-NMState.yamltest-fixtures/schemas/global/invalid/invalid-mapInterfaces-macAddress.yamltest-fixtures/schemas/global/invalid/malformed-mapInterfaces.yamltest-fixtures/schemas/global/invalid/missing-mapInterfaces.yamltest-fixtures/schemas/global/valid/networkConfig.yaml
to fix the different styles and remove ignored warnings from yamllint Signed-off-by: Rafa Porres Molina <rporresm@redhat.com>
rporres
force-pushed
the
strict-yaml-check
branch
from
8a28559 to
39f19df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix the different styles and remove ignored warnings from yamllint
Summary by CodeRabbit
Bug Fixes
Chores