WL-0MM8Q9IZ: Strengthen in-progress boost tests#787
Merged
rgardler-msft merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
- Rewrite non-stacking test (WL-0MM8STVWJ) to use cross-priority setup where stacked 1.875x would produce different sort order than correct 1.5x - Fix completed-child test (WL-0MM8STZHY) by creating unrelated item first so age tie-breaker validates boost removal rather than confirming creation order - Add multi-depth multi-in-progress test (WL-0MM8SU2R2) with in-progress items at child and grandchild levels verifying ancestor boost and non-stacking All 1191 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens three test cases for the in-progress boost scoring feature (PR #786) to eliminate false-pass scenarios identified during code review.
Changes
Non-stacking test (WL-0MM8STVWJ1UN4MWB): Rewrote to use cross-priority comparison (high open vs medium in-progress parent) with async delay for deterministic
createdAttie-breaking. The test now fails if boost stacking (1.5x * 1.25x = 1.875x) were applied instead of the correct non-stacking 1.5x.Completed-child test (WL-0MM8STZHY06200XY): Reversed item creation order so the unrelated item is created first. Previously the test passed due to age tie-breaker favoring the parent (created first), not because the ancestor boost was correctly removed. Now age favors the unrelated item, validating the boost is genuinely removed.
Multi-depth multi-in-progress test (WL-0MM8SU2R20PTDQ9I): Added new test case with in-progress items at both child and grandchild depth. Verifies the grandparent gets 1.25x ancestor boost, the in-progress parent gets 1.5x (not stacked with ancestor 1.25x), and the ancestor set de-duplication works correctly.
Verification
All 1191 tests pass (1 new test added). Tested multiple times for determinism.
Related Work Items