[codex] Fix Guan cosmic muon normalization#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes an extra azimuth factor from the analytic Guan cosmic-muon source formula used by
CosmicMuons.The formula already ends with the correct solid-angle conversion and azimuth integration,
so the leading
2*pimultiplied the generated muon rate by another factor of about2*pi.Impact
The generated muon kinematics are unchanged, but the REST source normalization and equivalent simulated time metadata are corrected. Existing productions made with the previous formula have equivalent times that are too small by approximately
2*pi, and should be rescaled if used for rate estimates.Validation
naf-iaxo.libRestGeant4.socontains the corrected formula without the leading2*pi.1.72e-2 cm^-2 s^-1, or about1.03 cm^-2 min^-1.