TRestDetectorElectronDiffusionProcess fix when several readout planes#128
Open
AlvaroEzq wants to merge 5 commits into
Open
TRestDetectorElectronDiffusionProcess fix when several readout planes#128AlvaroEzq wants to merge 5 commits into
AlvaroEzq wants to merge 5 commits into
Conversation
for more information, see https://pre-commit.ci
AlvaroEzq
changed the title
Member
|
Validation is failing, we should understand why? It was not properly implemented for single readouts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkIsInside parameter seems to be true by default but not when initfromconfigfile. Fix this
also, when the readout has several planes and checkisinside is false, the hit is processed for every plane causing duplication of hits and hits with wrong z pos.