Set IO_MEM_EXECUTABLE_IO for all non-IMapped peripherals#186
Open
neilberkman wants to merge 1 commit intorenode:masterfrom
Open
Set IO_MEM_EXECUTABLE_IO for all non-IMapped peripherals#186neilberkman wants to merge 1 commit intorenode:masterfrom
neilberkman wants to merge 1 commit intorenode:masterfrom
Conversation
neilberkman
force-pushed
the
fix/non-imapped-executable
branch
from
5e4f15e to
aadcbce
Compare
Previously, only ArrayMemory peripherals had the IO_MEM_EXECUTABLE_IO flag set, allowing instruction fetch via I/O callbacks. Any other non-IMapped peripheral (e.g. dynamically compiled C# peripherals) would trigger cpu_abort when the CPU tried to execute code from their address range. Generalize the check from `peripheral is ArrayMemory` to `!(peripheral is IMapped)` in three places: - SystemBus.RegisterInner: set flag when peripheral is first registered - SystemBus.MoveRegistrationWithinContext: preserve flag on re-registration - Machine.PostCreationActions: set flag for peripherals registered before CPU
neilberkman
force-pushed
the
fix/non-imapped-executable
branch
from
aadcbce to
3efe6a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IO_MEM_EXECUTABLE_IOflag fromArrayMemory-only to all non-IMappedperipheralsIMappedRegisterInner,MoveRegistrationWithinContext, andPostCreationActionsFixes #877