avoid exception when saving empty associations#283
Closed
balvig wants to merge 1 commit intoremi:masterfrom
balvig:empty_arrays
Closed
avoid exception when saving empty associations#283balvig wants to merge 1 commit intoremi:masterfrom balvig:empty_arrays
balvig wants to merge 1 commit intoremi:masterfrom
balvig:empty_arrays
Conversation
Author
|
Just noticed this is a duplicate of #281. Closing! |
balvig
added a commit
to cooksnaps/her
that referenced
this pull request
Sep 12, 2014
avoid exception when saving empty associations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #245
herseems to raise an exception when trying to save an object that is based on a JSON response with empty arrays for the associations. The problem was thatnextwould return nil and then crash when trying to merge the result with a hash into_params.