Skip to content

Add list of unsupported exchanges - #357

Merged
pedromcunha merged 2 commits into
mainfrom
pedro/int2-770-publish-a-list-of-known-blocked-exchanges
Jul 7, 2026
Merged

pedromcunha merged 2 commits into
mainfrom
pedro/int2-770-publish-a-list-of-known-blocked-exchanges

Conversation

@pedromcunha

Copy link
Copy Markdown
Member

No description provided.

@pedromcunha
pedromcunha requested a review from ted-palmer July 7, 2026 02:48
@mintlify

mintlify Bot commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟢 Ready View Preview Jul 7, 2026, 2:49 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@github-actions

github-actions Bot commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 1m 28s —— View job


Code Review: Add list of unsupported exchanges

Reviewed the diff (security/unsupported-exchanges.mdx, security/compliance.mdx, docs.json). security/ is out of scope for the v1 style guide (AGENTS.md §1.1), so I pattern-matched against existing pages in that folder.

Overall this is a clean, well-structured page and the reciprocal link with compliance.mdx + docs.json nav wiring are correct. One likely-real issue and a few small polish items below.


🔴 Error code likely wrong: BLOCKED_WALLET_ADDRESS

security/unsupported-exchanges.mdx:31 states quotes to a blocked recipient are rejected with a BLOCKED_WALLET_ADDRESS error. That code does not appear in the documented error table at references/api/api_core_concepts/handling-errors.mdx. The closest documented code is:

| `SANCTIONED_WALLET_ADDRESS` | The sender or recipient wallet address is sanctioned or blacklisted. |

If the API actually returns SANCTIONED_WALLET_ADDRESS, this page is documenting a code that doesn't exist and readers writing error-handling logic against it will silently miss the case. Please confirm the real code returned by the solver/API:

  • If it's SANCTIONED_WALLET_ADDRESS → update this line to match.
  • If BLOCKED_WALLET_ADDRESS is a genuine new code → add it to the handling-errors.mdx table so the two pages agree.

Fix this →


🟡 Minor / polish

  • Terminology mix (unsupported vs blocked). The title/description say "Unsupported Exchanges" / "not supported", but the body (:30, :31, :35) and the compliance.mdx:20 link text ("exchanges known to trigger blocks") say "blocked". Pick one framing or add a one-line sentence tying the two terms together, so a reader isn't unsure whether "unsupported" and "blocked" mean the same thing.
  • List ordering (:8–:26). The list is roughly alphabetical, but Exmo.me (:26) is stranded at the end after Wallex.ir. Move it up next to Exmo's alphabetical spot for consistency.
  • List entry formatting. Entries mix styles — handles (@CryptoBot, @wallet), domains (Sideshift.ai, Wallex.ir, Exmo.me), and plain names (Bit Pin, HTX (Huobi Global)). Not blocking, but normalizing to display names would read cleaner.
  • Heading level. The page opens with ### and has no ## (style guide §2.2 wants ## as the primary body heading). This matches the existing compliance.mdx pattern, so it's consistent with the folder — flagging only for awareness.

Links checked: /security/compliance, /resources/support, and the docs.json nav entry all resolve correctly. ✅

ted-palmer
ted-palmer previously approved these changes Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 1m 24s —— View job


Code Review: Add list of unsupported exchanges

Reviewed the current state of the diff (security/unsupported-exchanges.mdx +37, docs.json +1). security/ is out of scope for the v1 style guide (AGENTS.md §1.1), so I pattern-matched against security/compliance.mdx and cross-checked against references/api/api_core_concepts/handling-errors.mdx.

The page is clean and well-structured, and the docs.json nav wiring under Safety & Security is correct. One likely-real issue and a few polish items below.


🔴 Error code BLOCKED_WALLET_ADDRESS is not a documented code

security/unsupported-exchanges.mdx:31 says quotes to a blocked recipient are rejected with a BLOCKED_WALLET_ADDRESS error. I grepped the whole repo — that code appears only on this new page. The documented error table (references/api/api_core_concepts/handling-errors.mdx:33) instead has:

| `SANCTIONED_WALLET_ADDRESS` | The sender or recipient wallet address is sanctioned or blacklisted. |

If the API returns SANCTIONED_WALLET_ADDRESS, readers who write if (errorCode === 'BLOCKED_WALLET_ADDRESS') handling against this page will silently miss the case. Please reconcile the two:

  • If the real code is SANCTIONED_WALLET_ADDRESS → update line 31 to match (and consider linking to the error handling guide).
  • If BLOCKED_WALLET_ADDRESS is a genuine new code → add a row to the handling-errors.mdx table so the two pages agree.

Fix this →


🟡 Minor / polish

  • Terminology mix (unsupported vs blocked). The title/description say "Unsupported Exchanges" / "not supported", but the body (:30, :31, :33, :35) switches to "blocked". A reader can't tell whether the two terms are the same thing. Pick one framing, or add a one-liner in the intro tying "unsupported" and "blocked" together.
  • List ordering (:26). The list is otherwise alphabetical, but Exmo.me is stranded at the very end after Wallex.ir. Move it up to its alphabetical spot (near CoinEx/Crypto HK).
  • List entry formatting (:8–:26). Entries mix handles (@CryptoBot, @wallet), domains (Sideshift.ai, Wallex.ir, Exmo.me), and plain names (Bit Pin, HTX (Huobi Global)). Not blocking, but normalizing to display names would read cleaner.
  • Discoverability. The security/compliance.mdx mention was removed in commit f704eaa, so this page now links to Compliance but has no inbound link back — it's reachable only via the sidebar nav. That's fine, just flagging it was an intentional change.
  • Heading level (:28, :33). The page opens with ### sections and no ##, which the style guide (§2.2) would flag — but this matches the existing compliance.mdx pattern, so it's consistent within the security/ folder. Awareness only, not a blocker.

Links checked: /security/compliance and /resources/support both resolve. ✅


This is a review-only pass — I have not pushed any changes. The BLOCKED_WALLET_ADDRESS reconciliation is the one item worth confirming before merge, since it needs the actual code returned by the solver/API.

@pedromcunha
pedromcunha merged commit 420ab96 into main Jul 7, 2026
4 checks passed
@pedromcunha
pedromcunha deleted the pedro/int2-770-publish-a-list-of-known-blocked-exchanges branch July 7, 2026 13:50

This branch was successfully deployed

1 active deployment
staging — f704eaa9 Deployed Jul 7, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants