Fix base:writing-client-updates: add pre-draft fact-check checklist · claude-toolkit - #39
Open
dev-refact wants to merge 2 commits into
Open
Fix base:writing-client-updates: add pre-draft fact-check checklist · claude-toolkit#39dev-refact wants to merge 2 commits into
dev-refact wants to merge 2 commits into
Conversation
… claude-toolkit Refs asana#1217817153379702 Refact-Job: task_1217817153379702-a962d84292
Refs asana#1217817153379702 Refact-Job: task_1217817153379702-a962d84292
Author
|
Updated from the room. In the room: Refact Engineering (joined from a terminal 14:38 UTC, took over in the app 14:47 UTC). |
| 4. Draft the update in the correct format for the channel (full 7-part structure for email; headline-first short form for Slack). | ||
| 5. Never state a merge, deploy, or release status (e.g. "merged to stage", "promoted to production", "deployed") unless a corresponding tool action — an actual merge or deploy — was executed and observed in this session. If only a PR was opened, say exactly that; do not describe it as merged or released. | ||
| 6. Keep the first draft short: aim for roughly half a screen (about 120 words for email, 40 for Slack). Match length to the situation's complexity so the first draft does not need to be rewritten shorter. | ||
| 7. Offer to tighten or adjust tone before the user sends it. |
Member
There was a problem hiding this comment.
use simpler english words for this item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task done.
base:writing-client-updates→ v1.2.0.Where the work landed. The task sits on the Skill Analyzer board, so
open-project --taskgave meskill-radar— which holds no catalog skill files (its toolkit clone is read-only by design). The skill lives inrefactco/claude-toolkit, which I opened as well. The PR is on claude-toolkit; skill-radar is untouched.All four acceptance criteria are in. A new
## Pre-draft fact checksection inreferences/writing-client-updates.md, with a step 3 inSKILL.mdthat runs it before drafting:On the collision check (criterion 4): no collision, and it's recorded in the changelog. The ~120-word ceiling and the merge/deploy guard from 1.1.0 are unchanged as steps 5 and 6. The fact check is a gate on your notes, not a section of the message, so it costs the draft nothing, and it caps assumption-marking at a few words — a claim needing a paragraph of hedging gets cut instead. It removes rewrite passes rather than adding length.
Also shipped: the per-skill CHANGELOG entry with the four verified quotes and the
radar:expectationmarker (baseline 3 → target 1, 4w); pack 1.11.1 → 1.12.0 and marketplace 2.16.0 → 2.17.0 withsync-codex.mjsregenerating the derived catalogs.sync-codex --check,check-plugins.pyandnode --test tests/*.test.mjs(64 tests) all pass. I also repairedSKILL.mdsteps 4 and 5, which had been running together on one line since 1.1.0 — the merge/deploy guard was buried mid-sentence.Two things I flagged rather than decided, proposed as a comment on the task:
Memory: one knowledge doc,
refact-os/knowledge/shipping-a-catalog-skill-fix.md— the board/repo split, what one fix touches, and why the version bump is what makes a fix measurable. The gap itself was already tracked in the W37 radar concern entry, so I didn't duplicate it.In the room: Refact Engineering (joined from a terminal 14:38 UTC).
Refs asana#1217817153379702