Repository navigation
Allow additional types for valid_ibinspectable - #6963
Open
GtechGovind wants to merge 1 commit into
Open
GtechGovind wants to merge 1 commit into
GtechGovind wants to merge 1 commit into
Conversation
Generated by 🚫 Danger |
GtechGovind
marked this pull request as ready for review
October 18, 2026 16:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I added an empty-default
additional_typesoption tovalid_ibinspectableso projects can explicitly allow supported typealiases such asCLLocationDegrees.The option matches exact written type names. Configuring
Angledoes not implicitly allowAngle?orAngle!; those spellings must be listed separately if supported. Existing built-in types and property checks remain unchanged. This does not resolve aliases semantically or verify Interface Builder compatibility for configured names.I added configured examples covering default rejection, qualified names, duplicates, optional spellings, existing built-ins, immutable properties, missing annotations, and explicit read-only getters. Configuration tests cover severity compatibility and invalid option values. The generated default configuration and changelog are updated.
Closes #1925.
Validation
swift run swiftlint-dev rules register— regenerated configuration successfully.swift test --filter ValidIBInspectable— generated-rule suite and three configuration tests passed.swift test— passed locally on macOS.swift run swiftlint— zero violations.The changelog intentionally retains the two trailing spaces required by CONTRIBUTING. I have not run the separate Xcode, Bazel, Docker/Linux, or Windows matrix locally; those checks remain for remote CI.