Repository navigation
Conversation
Allow rules to opt out of inline swiftlint:disable regions while remaining configurable through .swiftlint.yml. This supports migration rules that mirror diagnostics or SDK deprecations introduced by newer Swift and Xcode versions before those toolchains are fully shipped or deployed. Such requirements should not be bypassed at individual call sites while compatibility enforcement is still needed. Add core coverage for rule-specific and all disable commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4589230d-cb68-4337-8fff-758c9944a478
Generated by 🚫 Danger |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
NonSuppressibleByRegionRule, allowing rules to opt out of inlineswiftlint:disableregions while remaining configurable through.swiftlint.yml.This is useful for migration rules that mirror compiler diagnostics or SDK
deprecations introduced by newer Swift and Xcode versions before those
toolchains are fully shipped or deployed. These compatibility requirements
should not be bypassed at individual call sites while enforcement is needed.
The behavior applies to both rule-specific disable commands and
swiftlint:disable all.Testing
swift test --filter RuleTestsswift run swiftlintNotes
Repository configuration remains authoritative: conforming rules can still be
disabled through
.swiftlint.yml.