Repository navigation
Fix false positives in vertical_parameter_alignment_on_call with Unicode - #6535
Open
theamodhshetty wants to merge 1 commit into
Open
theamodhshetty wants to merge 1 commit into
theamodhshetty wants to merge 1 commit into
Conversation
Generated by 🚫 Danger |
SimplyDanny
reviewed
Apr 10, 2026
theamodhshetty
force-pushed
the
codex/fix-vertical-parameter-alignment-unicode
branch
from
October 1, 2026 22:06
ba57504 to
f138e9f
Compare
Contributor
Author
|
@SimplyDanny Could you take another look when you have time? The Unicode alignment feedback is addressed in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vertical_parameter_alignment_on_callcompared UTF-8 byte columns, causing false positives when a non-ASCII identifier preceded the first argument.This compares grapheme-cluster columns, following the conversion used by the declaration-alignment rule. Source lines are cached per visitor to avoid repeatedly reading the whole file for each argument. Added regressions cover the reported Cyrillic identifier, the reviewer's
😵💫example, decomposed accents, and genuinely under-/over-indented arguments. The branch is rebased onto currentmainand uses current example macros.Validation:
swift test --filter 'ControlStatementRuleGeneratedTests|VerticalParameterAlignmentOnCallRuleGeneratedTests'passes in a temporary combined checkout with the exact rule source from this branch; strict lint passes. Whitespace checks pass with Markdown hard-break trailing spaces allowed. Full platform/performance validation remains with CI.Fixes #6467.