examples/sdl2: Improve synchronization.#103
Open
lubosz wants to merge 1 commit intorealitix:masterfrom
Open
Conversation
Regains these 1000 FPS by implementing a proper fix for realitix#55. * Create and use queue submit fences per swap chain buffer. * Increase the semaphore count for "image_available" and "render_finished" from 1 to swap chain size. * Introduce `recycled_semaphores` list to decouple `image_available` semaphore retrieval from `image_index`. * Use `vkQueueWaitIdle` only when `vkAcquireNextImageKHR` fails. * Pass `VkSubmitInfo` direclty to `vkQueueSubmit`, avoiding extra ffi array. This synchronization is based on the hello triangle example from the Khronos Vulkan-Samples repo: https://github.com/KhronosGroup/Vulkan-Samples/tree/main/samples/api/hello_triangle_1_3 This solution runs cleanly on VK_LAYER_KHRONOS_validation 1.4.313.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regains these 1000 FPS by implementing a proper fix for #55.
recycled_semaphoreslist to decoupleimage_availablesemaphore retrieval fromimage_index.vkQueueWaitIdleonly whenvkAcquireNextImageKHRfails.VkSubmitInfodireclty tovkQueueSubmit, avoiding extra ffi array.This synchronization is based on the hello triangle example from the Khronos Vulkan-Samples repo:
https://github.com/KhronosGroup/Vulkan-Samples/tree/main/samples/api/hello_triangle_1_3
This solution runs cleanly on VK_LAYER_KHRONOS_validation 1.4.313.0.