fix: Make EventTarget methods enumerable

[retyui]

Summary:

By spec EventTarget should have 3 enumerable methods (addEventListener, removeEventListener and dispatchEvent)

Changelog:

[GENERAL] [CHANGED] - Make EventTarget methods enumerable by spec

Test Plan:

Create aRN app and run code with/without commented code

// Object.defineProperties(EventTarget.prototype, {
//   addEventListener: { enumerable: true },
//   removeEventListener: { enumerable: true },
//   dispatchEvent: { enumerable: true },
// });

console.log('Start');
for (const key in new EventTarget()) {
  console.log({ key });
}
console.log('End');

[Abbondanzo]

This isn't something we do anywhere else in the project. Can you explain the motivation or the spec you're referencing? Even Chrome doesn't do this. You can still call Object.keys(EventTarget.prototype) without this change

[retyui]

@Abbondanzo

Can you explain the motivation or the spec you're referencing?

I want to align EventTarget implementation to be compatible with spec.

--

Even Chrome doesn't do this.

How you can prove it? As I see Chrome, Firefox, Safari, Node.js: all of them implements EventTarget with methods as enumerable: true

[Abbondanzo]

Lazily, I was only trying Object.keys(new EventTarget()) and not attempting to turn that into an iterator, so my mistake. This is a good starting point. For the sake of consistency, do you plan to make additional changes to other WebIDL classes (like IntersectionObserver, Performance, CustomEvent, etc.)?

[meta-codesync]

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D108908236.

[retyui]

do you plan to make additional changes to other WebIDL classes (like IntersectionObserver, Performance, CustomEvent, etc.)?

@Abbondanzo I hope to back to them after merging abort-controller PR #57230