Replacing logback by log4j2 - #5
Merged
Merged
Conversation
Member
|
Thank you, @josemduarte. Tested and working. I also added a new bean to log graphql queries at the info level (they were only logged at the debug level). I will merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spring default is logback. We use log4j2 in most other places, including in seqmotif spring app. This should make things more standard and easier to manage.
This is tested in K8s and works well (the Helm chart was already assuming log4j2). Some changes will be needed in SysAdmin, which in effect was assuming log4j2 but isn't configured correctly right now.