Skip to content

RO-5068 Refactor IDMapper service to use new groups collections - #23

Open
ChunxiaoB wants to merge 8 commits into
masterfrom
dev-cb-ro5005
Open

RO-5068 Refactor IDMapper service to use new groups collections#23
ChunxiaoB wants to merge 8 commits into
masterfrom
dev-cb-ro5005

Conversation

@ChunxiaoB

Copy link
Copy Markdown
Contributor
  • The group_metadata collection contains the content previously stored in four separate group collections.
  • Added filtering by group_provenance_id to preserve the existing data retrieval flow and behavior.
  • Introduced a centralized bi-directional mapping between aggregation_method and group_provenance_id.
  • The IDMapper client continues to use aggregation_method as input. The IDMapper service translates the input to group_provenance_id for getting the results.
  • Centralizing the mapping logic eliminates scattered hard-coded enum dependencies and simplifies future maintenance.

The PR passed all Postman tests.

@josemduarte josemduarte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, as long as all other tests look good. Now it will just need adapting to the new split group_metadata collections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants