fix(alert-dialog): remove footer border and default showCloseButton to false#785
fix(alert-dialog): remove footer border and default showCloseButton to false#785rohanchkrabrty merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rohanchkrabrty
force-pushed
the
worktree-alertdialog
branch
from
819dfbc to
6cc479a
Compare
rohanchkrabrty
force-pushed
the
worktree-alertdialog
branch
from
6cc479a to
7960bed
Compare
…o false - Removed the body→footer border on AlertDialog (scoped override that doesn't affect Dialog). - BREAKING: showCloseButton default flipped from true to false. Existing consumers relying on the default will need to set showCloseButton explicitly. Worth a changelog/release-notes callout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rohanchkrabrty
force-pushed
the
worktree-alertdialog
branch
from
7960bed to
47db67d
Compare
2 participants
Summary
.body { border-bottom }to:where(.body) + .footer { border-top }(visually identical; the:where()keeps the rule's specificity at.footerso consumers can override cleanly)..footer { border-top: 0 }— no:has(), no class-on-body trick.showCloseButtondefault flipped fromtruetofalse. Existing consumers relying on the default close button will need to setshowCloseButtonexplicitly — worth a changelog/release-notes callout.