feat(wanda): add Platform field for cross-platform image resolution #334
Conversation
Allow targeting linux/arm64 from mac. Resolves issue 2025/12/30 17:23:41 resolve bases: resolve remote image ubuntu:22.04: fetch image ubuntu:22.04: no child with platform darwin/arm64 in index ubuntu:22.04 Signed-off-by: andrew <[email protected]>
Summary of ChangesHello @andrew-anyscale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the image resolution capabilities by introducing a mechanism to explicitly define the target platform (OS/architecture). This change addresses issues where the system might fail to resolve remote images due to platform mismatches, particularly when building for a different architecture than the host. By allowing users to specify the desired platform, it ensures that the correct image variant is fetched, improving the robustness of cross-platform build processes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a Platform field to enable cross-platform image resolution, which is a valuable addition. The implementation is sound, but I've identified an area for improvement in the platform string parsing logic. The current approach could lead to silent failures or incorrect behavior when given malformed input. I've provided a suggestion to make the parsing more robust by adding validation and error handling. The rest of the changes are well-implemented.
| if config.Platform != "" { | ||
| parts := strings.SplitN(config.Platform, "/", 2) | ||
| if len(parts) == 2 { | ||
| targetOS = parts[0] | ||
| targetArch = parts[1] | ||
| } | ||
| } |
There was a problem hiding this comment.
The current platform string parsing is not robust. It silently ignores malformed platform strings (e.g., "linux") by falling back to the host's platform, and can mis-parse strings like "/arm64" or "linux/". This could lead to unexpected behavior. It would be better to validate the format and return an error for invalid input.
| if config.Platform != "" { | |
| parts := strings.SplitN(config.Platform, "/", 2) | |
| if len(parts) == 2 { | |
| targetOS = parts[0] | |
| targetArch = parts[1] | |
| } | |
| } | |
| if config.Platform != "" { | |
| parts := strings.SplitN(config.Platform, "/", 2) | |
| if len(parts) != 2 || parts[0] == "" || parts[1] == "" { | |
| return nil, fmt.Errorf("invalid platform format: %q, expected \"os/arch\"", config.Platform) | |
| } | |
| targetOS = parts[0] | |
| targetArch = parts[1] | |
| } |
Signed-off-by: andrew <[email protected]>
Allow targeting linux/arm64 from mac. Resolves issue 2025/12/30 17:23:41 resolve bases: resolve remote image ubuntu:22.04: fetch image ubuntu:22.04: no child with platform darwin/arm64 in index ubuntu:22.04