Skip to content

Conversation

@andrew-anyscale
Copy link
Contributor

adds podman backend via podman_cmd. Requires
having podman already installed + available via PATH

I still need to battletest this, but this is the
general shape!

Topic: add-podman-backend
Relative: refactor-for-podman

Signed-off-by: andrew [email protected]

adds podman backend via podman_cmd. Requires
having podman already installed + available via PATH

I still need to battletest this, but this is the
general shape!

Topic: add-podman-backend
Relative: refactor-for-podman

Signed-off-by: andrew <[email protected]>
@andrew-anyscale
Copy link
Contributor Author

Reviews in this chain:
#329 [wanda] refactor docker_cmd to be container_cmd
 └#330 [wanda] add podman backend

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Dec 19, 2025

# head base diff date summary
0 afe8d89b cbee1681 diff Dec 19 1:33 AM 6 files changed, 85 insertions(+), 3 deletions(-)
1 221e0934 cbee1681 diff Dec 19 2:22 AM 3 files changed, 43 insertions(+), 16 deletions(-)
2 eae75ffb b521b0f0 rebase Dec 19 2:26 AM 0 files changed

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @andrew-anyscale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the wanda project's flexibility by adding comprehensive support for Podman as a container runtime. It involves integrating Podman-specific command execution, error handling, and environment setup, alongside a new command-line option for users to choose between Docker and Podman. This change aims to provide users with more choices for their containerization needs.

Highlights

  • Podman Backend Integration: Introduced a new backend for Podman, allowing it to be used as an alternative container runtime to Docker.
  • Podman Error Handling: Modified the inspectImage function to correctly handle Podman's specific exit code (125) when an image is not found, preventing false errors.
  • Podman Availability Check: Updated the podmanAvailable utility function to accurately check for the presence of the Podman executable in the system's PATH.
  • Dynamic Container Runtime Selection: Enhanced the newContainerCmd factory function to dynamically create either a Docker or Podman command instance based on the configured ContainerRuntime.
  • New Podman Command Implementation: Added a dedicated podman_cmd.go file which encapsulates the logic for executing Podman commands and managing relevant environment variables.
  • CLI Flag for Podman: Implemented a new command-line flag --podman in the main application to explicitly select Podman as the desired container runtime.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for using Podman as a container backend, which is a great addition. The implementation is straightforward and follows the existing structure for the Docker backend. I've made a few suggestions to improve code clarity, maintainability, and testing. Specifically, I've recommended refactoring the new tests to be table-driven, improving how environment variables are handled for Podman, and renaming a command-line flag for better user experience. Overall, this is a solid contribution.

@andrew-anyscale andrew-anyscale marked this pull request as draft December 19, 2025 01:56
Topic: add-podman-backend
Relative: refactor-for-podman

Signed-off-by: andrew <[email protected]>
@andrew-anyscale andrew-anyscale marked this pull request as ready for review December 19, 2025 02:22
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/add-podman-backend branch from 221e093 to eae75ff Compare December 19, 2025 02:26
@gitar-bot
Copy link

gitar-bot bot commented Dec 19, 2025

🎸 Gitar is monitoring - nothing to report at this time

Gitar will review changes, analyze CI failures, apply rules, and respond to comments when relevant.

Options

Auto-apply is off Gitar will not commit updates to this branch.
✅ Code review is on Gitar will review this change.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply ✅ Code review Compact
gitar auto-apply:on         
gitar code-review:off         
gitar display:verbose         

This comment will update automatically (Docs)

@andrew-anyscale andrew-anyscale marked this pull request as draft December 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants