Added page for listing vending items#193
Open
aries-delossantos wants to merge 1 commit intorathena:masterfrom
aries-delossantos:feature-vending-list-item
Open
Added page for listing vending items#193aries-delossantos wants to merge 1 commit intorathena:masterfrom aries-delossantos:feature-vending-list-item
aries-delossantos wants to merge 1 commit intorathena:masterfrom
aries-delossantos:feature-vending-list-item
Conversation
sanasol
reviewed
Mar 31, 2019
Member
|
I'm inclined to agree with @S-anasol |
Daegaladh
suggested changes
Apr 4, 2019
Member
Daegaladh
left a comment
Daegaladh
left a comment
There was a problem hiding this comment.
I agrre with Akkarin and S-anasol.
Also, please replace all hardcoded texts with lang variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rathena.org/board/topic/116038-fluxcp-different-vending-page/