Adds a driver for the new series of Studio DAC8x soundcards #7197
+1,054
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new driver for complex, multi-channel soundcards. The cards have their own management using an onboard MCU for clock generation and controls of various DACs or ADCs. Data provided by the MCU's register via I2C allows flexible configuration of a number of DAC and ADC channels, volumes, gain settings and other functions like mute and filter settings. Signed-off-by: j-schambacher <[email protected]>
Adds two overlays for clock consumer and provider mode. Only compatible with Pi 5 (bcm2712). Signed-off-by: j-schambacher <[email protected]>
Adding the Studio DAC8x to the Pi 5 defconfig. Signed-off-by: j-schambacher <[email protected]>
Contributor
Author
|
I'll wait for further feedback before I'll add the forgotten README .... |
pelwell
reviewed
Jan 15, 2026
| "gpio24", "gpio25", "gpio26", | ||
| "gpio27"; | ||
| bias-disable; | ||
| status = "okay"; |
Contributor
There was a problem hiding this comment.
This line is always unnecessary (no status means enabled), except where it overwrites a status = "disabled";, but for gpio/pin declarations like this it is meaningless.
| "gpio24", "gpio25", "gpio26", | ||
| "gpio27"; | ||
| bias-disable; | ||
| status = "okay"; |
|
|
||
| static int hb_controller_probe(struct platform_device *pdev) | ||
| { | ||
| struct i2c_adapter *adap = i2c_get_adapter(1); |
Contributor
There was a problem hiding this comment.
This was a surprise - embedding what is effectively the codec driver. How do you arrange the I2C1 is enabled, since the overlays aren't doing so?
| __overlay__ { | ||
| compatible = "hifiberry,hifiberry-studio-dac8x"; | ||
| i2s-controller = <&i2s_clk_consumer>; | ||
| clk-provider; |
Contributor
There was a problem hiding this comment.
This would not be necessary if the Pro had a different compatible string, but you may have reasons to prefer doing it like this - I'm not really bothered either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we are trying a implement a new driver concept for more complex, multi-channel soundcards.
All cards have their own firmware on a MCU managing controls of various DACs or ADCs. During the initial setup the driver
reads some basic configuration like UUID, number of DAC and ADC channels etc. Based on this fundamental data volume and gain controls are generated and applied. Later, we may implement more specific controls based on UUID and/or other register settings. That's also the reason why there are already more definitions than the current driver uses.
We hope this approach could ease maintenance on HW and SW side.
Joerg