Allow for "attachment" parameter in PDFResponse content-disposition header#39
Open
gutmandev wants to merge 3 commits intoramibch:nextfrom
Open
Allow for "attachment" parameter in PDFResponse content-disposition header#39gutmandev wants to merge 3 commits intoramibch:nextfrom
gutmandev wants to merge 3 commits intoramibch:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for this app -- very useful!
I recently ran into a situation where I wanted the the user to automatically download the file in a
PDFResponse, rather than just viewing it in their browser. This can be done by adding theattachmentparameter to theContent-Dispositionheader (docs).I added a new kwarg
as_attachmenttoPDFResponseandrender_to_pdf. It defaults toFalse, so I think this change should be backward compatible. I modeled the code after Django'sFileResponseclass.Please let me know if you think this would be a good addition to this app, and/or if you have any feedback about the style, implementation, etc.