expand repeated lrc timestamps into their own lines - #92
Open
holofermes wants to merge 1 commit into
Open
holofermes wants to merge 1 commit into
holofermes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LRC allows a repeated line to carry several timestamps, it's in the first example of the basic format on https://en.wikipedia.org/wiki/LRC_(file_format), and LRCLIB serves such lines verbatim:
ParseLrcLineonly reads the first tag, so the other tags end up as lyric text and the later repetitions just don't exist. As of now, I found Beck's Paper Tiger has this in.This makes
ParseLrcLinereturn oneLineper timestamp with the tags stripped from the words, and both providers sort after expanding since the repeats land out of order. That does change the signature fromLineto[]Line.Totally fine keeping the old signature instead of breaking the API.