Map phone sleep/wake to DS lid close/open - #1589
Open
DLCSharp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the phone screen turns off, the DS lid close input is now triggered so the running game can play their sleep sound (if supported) before emulation is paused.
On screen wake, the lid reopens allowing the game to play their wake sound.
On sleep, games have a 3s window to react on sleep before emulation is paused. There can be slight audio crunchiness during this window because of Android's handling : a service is used to keep the app in foreground which helps a lot.
It is not a necessary feature, but it's fun and makes the experience more immersive, especially on dual-screen handhelds like the Ayn Thor.
Tested games
Test devices : Ayn Thor, Samsung Galaxy S23+
Confirmed working with no issues :
Full list of known games which play sounds on wake/sleep : https://niwanetwork.org/wiki/Sleep_Mode