Rename the trainer group and cell to TrainerController and TrainerCell - #2176
Open
fzyzcjy wants to merge 2 commits into
Open
Rename the trainer group and cell to TrainerController and TrainerCell#2176fzyzcjy wants to merge 2 commits into
fzyzcjy wants to merge 2 commits into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 4, 2026 14:17
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
from
August 6, 2026 03:47
c31b653 to
fac7194
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 6, 2026 03:47
897c0ec to
03a6a74
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
2 times, most recently
from
August 9, 2026 23:32
dfc4680 to
d11bd3a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 10, 2026 00:44
98c9464 to
3f4bf39
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
2 times, most recently
from
August 10, 2026 06:01
190c45a to
7bbce62
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 10, 2026 06:02
3f4bf39 to
c240135
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
from
August 10, 2026 16:06
7bbce62 to
ca43f31
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 10, 2026 16:06
c240135 to
6e08c81
Compare
fzyzcjy
changed the base branch from
tom/refactor-miles/op13-160
to
tom/refactor-miles/op13-171
August 10, 2026 16:12
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
from
August 10, 2026 16:33
ca43f31 to
c706796
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-171
branch
from
August 10, 2026 16:34
b95dc89 to
3a78d51
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
from
August 11, 2026 00:45
c706796 to
098853c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-171
branch
from
August 12, 2026 02:48
3a78d51 to
95de5ea
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
from
August 12, 2026 02:48
098853c to
8021c90
Compare
The train actor used to tell the rollout side which weights the engines now serve via `self.rollout_manager`, but that attribute stopped being assigned once the actor was decoupled from the rollout side, leaving two dead call sites: the FSDP one also referenced an unimported `ray`. The executor's `weight_version` therefore stayed None forever and every sample it collected went to training unstamped. The actor's `update_weights` now answers the version it broadcast, the trainer controller passes it up, and the driver writes it into the executor through one `update_weights` helper the three training loops share. An actor that skipped the broadcast answers None and nothing is published. The driver owns the write because it is the only place that holds both handles for the whole chain: the controller's own executor handle goes away when the trainer controller becomes an independent worker.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-171
branch
from
August 12, 2026 09:32
95de5ea to
3da72e3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-142
branch
from
August 12, 2026 09:32
a58b3f6 to
0963e0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837
ci-sglang-pr: tom/refactor-miles-repo-sglang/deliver-1