Crash rollout engines from the soak harness instead of the controller - #2120
Open
fzyzcjy wants to merge 1 commit into
Open
Crash rollout engines from the soak harness instead of the controller#2120fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
4 times, most recently
from
August 4, 2026 02:36
f14c938 to
7666c0c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 4, 2026 02:36
658b39c to
5ba57d0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
from
August 4, 2026 06:53
7666c0c to
f7bfdf4
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:53
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 4, 2026 06:53
5ba57d0 to
ce2795f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
2 times, most recently
from
August 4, 2026 07:31
a88efd2 to
a97d34d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 4, 2026 07:58
ce2795f to
dbfdd32
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
from
August 6, 2026 03:46
a97d34d to
9123e88
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 6, 2026 03:46
dbfdd32 to
0521fa7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
from
August 6, 2026 07:04
9123e88 to
6a7a947
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 6, 2026 07:04
0521fa7 to
2a12380
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
from
August 9, 2026 23:31
6a7a947 to
308c241
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
2 times, most recently
from
August 10, 2026 00:44
c062466 to
cf6b367
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
2 times, most recently
from
August 10, 2026 06:00
68cd73d to
318bd70
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 10, 2026 06:00
cf6b367 to
dcffe00
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 10, 2026 16:06
dcffe00 to
a7917f2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
2 times, most recently
from
August 10, 2026 16:33
01505ee to
ad75a46
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 12, 2026 02:48
0ac3425 to
fdbd7af
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
2 times, most recently
from
August 12, 2026 09:32
e645ff3 to
cac8e31
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 12, 2026 14:31
4dc05ec to
c120733
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
from
August 12, 2026 14:31
cac8e31 to
318a3b5
Compare
The controller injected CI faults into itself, which needed it to reach into its own engines and to know it was under test. Faults are now injected the way trainer ones already are, over the api server, so the controller keeps no test hook at all. The colocated mode this adds is the most direct evidence that colocate x ft works: an engine is crashed mid training, relaunched gated, and only comes back to Running at the next weight update window.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-112
branch
from
August 12, 2026 14:36
318a3b5 to
a113d13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-127
branch
from
August 12, 2026 14:36
c120733 to
5620b7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837