Skip to content

Launch sglang engines gated and release them once they are running - #2096

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-117from
tom/refactor-miles/op13-118
Open

Launch sglang engines gated and release them once they are running#2096
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-117from
tom/refactor-miles/op13-118

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from 9a663a9 to f3701c7 Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 8423dcd to 0fdb385 Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from f3701c7 to 0cfae7d Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 0fdb385 to e0a4dce Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from 0cfae7d to 2a9824b Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from e0a4dce to ee99103 Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy requested a review from Rockdu as a code owner August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from 2a9824b to 13811cb Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from ee99103 to 109bed1 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from 13811cb to 2589578 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 109bed1 to b243dc4 Compare August 4, 2026 07:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from 2589578 to 206df79 Compare August 4, 2026 07:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from b243dc4 to ce501c4 Compare August 6, 2026 03:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch 2 times, most recently from bfc30f2 to e024b0e Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 165008b to 0e6df86 Compare August 9, 2026 23:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch 2 times, most recently from 14427e3 to 9d64207 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 4aef8a7 to fd52c7c Compare August 10, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from 9d64207 to 37be5f8 Compare August 10, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from fd52c7c to 536beb7 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from 37be5f8 to 5877b7a Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 536beb7 to c472209 Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch 2 times, most recently from 22b54d0 to 2cd2419 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from c472209 to 2441d03 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch 2 times, most recently from 97b950a to cdc6b8b Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 71b8062 to 1b1e4c2 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch 3 times, most recently from de3bffa to cca083c Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 503f4b5 to 9442cbe Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch 4 times, most recently from 8ff168d to b2fa901 Compare August 13, 2026 06:39
Pass the allocated gate port to every engine so sglang idles at its
out-of-band control port instead of initializing straight away, and have
RayWorkerManager release each cell after its workers were started. The
release retries until the port answers, because it only starts listening
once the engine reaches its gate.
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-118 branch from b2fa901 to fd2f4ec Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-117 branch from 360867b to fd391b2 Compare August 14, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant