Extend FP32 MoE numerics to low-precision recipes and registered activations - #77
Draft
zianglih wants to merge 3 commits into
Draft
Extend FP32 MoE numerics to low-precision recipes and registered activations#77zianglih wants to merge 3 commits into
zianglih wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
@HumansAnd
Generalizes the
moe_activation_in_fp32andmoe_combine_in_fp32options introduced by radixark/Megatron-LM#68 across supported Transformer Engine low-precision routed-MoE paths. It also replaces the SwiGLU-specific activation implementation with a reusable registration surface, with SwiGLU and squared ReLU as built-ins.Changes
delayed,tensorwise,blockwise, andmxfp8) in E4M3 and HYBRID formats, plus the standard NVFP4 recipe.TEGroupedMLProuted experts; a registered activation/gating pair for activation-in-FP32; and unfused AlltoAll with FP32 router probabilities for combine-in-FP32.tests.functional_tests.test_cases.common.moe_fp32_low_precisionfor the low-precision runtime matrix.Scope
This is a model- and architecture-neutral Megatron-core feature: there are no Inkling-, Nemotron-, or other model-specific checks or call paths. No Miles, SGLang, or Transformer Engine source changes are required. The activation option covers routed
TEGroupedMLPexperts; shared experts remain outside this path. Custom and per-module quantization recipes remain outside the supported contract.Validation
git diff --checkradixark/miles:dev-202608041247: all passedpy_compileon all six changed Python filesdelayed,tensorwise,blockwise,mxfp8, andnvfp4) in SwiGLU activation+combine mode and combine-only modeThe runtime harness verifies the active Transformer Engine recipe class, quantized FC1 and FC2 grouped GEMMs, one local expert per EP8 rank, cross-rank routing, quantization padding, FP32 router probabilities reaching the final unfused AlltoAll unpermute when combine-in-FP32 is enabled, the registered FP32 activation autograd node, and finite nonzero hidden/router/expert gradients over two iterations.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.