[WIP] Add NVFP4 fake QAT for grouped experts - #75
Draft
zianglih wants to merge 2 commits into
Draft
Conversation
|
@zianglih Hello, Since this is targeting B-series cards, why is NVFP4 QAT still needed? I noticed you also support NVFP4 training for RL. If we directly use real FP4 computation, wouldn’t the training-inference consistency be better? Why do we need to support both paths? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds opt-in Transformer Engine-backed NVFP4 fake quantization-aware training for routed MoE grouped FC1/FC2 weights.
Warning
Experimental / WIP. This is the Megatron half of the NVFP4 QAT RL path and has not yet been validated on a GPU devbox.
Implementation
This mirrors the existing INT4 fake-QAT path in
TEGroupedLinear._get_weight_tensors:OPEN_TRAINING_NVFP4_FAKE_QAT_FLAG=1creates a cached publicte.pytorch.NVFP4Quantizer.main_gradcontract is retained.The quantizer mirrors Miles' existing NVFP4 conversion/export contract:
NVTE_NVFP4_4OVER6=weights|allenables weight-side 4over6.NVTE_NVFP4_4OVER6_E4M3_USE_256=weights|allselects E4M3 max 256 when weight-side 4over6 is active; otherwise the bound is 448.NVTE_NVFP4_4OVER6_ERR_MODEselects the 4over6 error metric and defaults toMAE.Scope and limitations
This PR affects routed MoE expert FC1/FC2 weights using TE grouped linear only. It does not add fake quantization to dense MLPs, shared experts, sequential or legacy experts, activations, optimizer state, parameter gather, or native FP4 GEMMs.
The current Miles Qwen recipe uses expert tensor parallel size 1. With expert TP greater than 1, the local-shard amax used here can differ from full-weight rollout conversion because the mirrored quantizer contract disables amax reduction. Generic expert-TP parity is therefore follow-up validation/work rather than a claim of this draft.
Dependencies
Validation
Passed static check:
git diff origin/miles-main...HEAD --checkThe repository pre-commit hooks were attempted, but the pre-existing INT4 block in this file triggers formatting and missing-docstring changes. Those unrelated changes were deliberately excluded to keep this PR additive and NVFP4-only. Per request, no unit or functional tests, benchmarks, accuracy runs, or GPU/devbox validation were performed before opening this draft.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.