Add opt-in FlashInfer-fast activations for rollout parity - #73
Draft
zianglih wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds an opt-in Megatron SwiGLU implementation that matches the fast activation arithmetic used by FlashInfer's SM100 CuTe DSL MoE path.
The implementation is disabled by default and enabled at process startup with:
Why
Miles uses Megatron for training and FlashInfer for rollout inference. Megatron's standard
F.silupath and FlashInfer's fastexp2/reciprocal approximation can produce different SwiGLU values, which is undesirable for RL rollout/training consistency.The target arithmetic is the FlashInfer SM100 CuTe sequence:
Source review found that FlashInfer's CuTe, CUTLASS, CUDA, and TRT-LLM paths use the same broad fast-math family, although this PR claims exact arithmetic alignment only with the explicit SM100 CuTe sequence.
Implementation
fast_activations.pymodule that owns the environment policy, fast SwiGLU forward, and analytic training backward.GroupedMLPSwiGLU path through the existing custom autograd wrappers when enabled.The experiment uses the DeepSeek-V3 activation shape
[7168, 4096] -> [7168, 2048]and excludes GEMM, quantization, routing, permutation, unpermutation, and MoE combine.Nemotron-3's ReLU2 path was also audited. It uses only
max(x, 0)followed by self-multiplication, with no approximate transcendental operation. The B200 experiment found exact agreement, so this PR does not add an alternate ReLU2 implementation.Validation
Run on NVIDIA B200 with PyTorch
2.11.0+cu130, CUDA 13.0, and CUTLASS DSL 4.5.2:7 passedwith the environment disabled and7 passedwith it enabled.python3 -m py_compilepassed for the new implementation, test, and experiment files.git diff --checkpassed.sgl-kernelTop-K, MilestorchTop-K, and zero BF16 boundary layers. Independent temperature-1 runs appeared lower with the fast toggle, but they sampled different responses.The full reproduction procedure and result table are in
docs/discussions/flashinfer-fast-activations-alignment.md.Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)The repository autoformatter and pre-commit were not run for this experiment branch.
Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.