Skip to content

Skip CI checks for PRs with only design notes changes#11567

Open
kachawla wants to merge 1 commit intoradius-project:mainfrom
kachawla:skip-checks-design-notes
Open

Skip CI checks for PRs with only design notes changes#11567
kachawla wants to merge 1 commit intoradius-project:mainfrom
kachawla:skip-checks-design-notes

Conversation

@kachawla
Copy link
Copy Markdown
Member

@kachawla kachawla commented Apr 6, 2026

Description

Skip PR CI checks for PRs that only contain design notes changes.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

…for PRs that only contain design notes changes.

Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Copilot AI review requested due to automatic review settings April 6, 2026 19:02
@kachawla kachawla requested review from a team as code owners April 6, 2026 19:02
@radius-functional-tests
Copy link
Copy Markdown

radius-functional-tests bot commented Apr 6, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository kachawla/radius
Commit ref f40df2a
Unique ID func884cc9a5c0
Image tag pr-func884cc9a5c0
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func884cc9a5c0
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func884cc9a5c0
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func884cc9a5c0
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func884cc9a5c0
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func884cc9a5c0
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable change-detection workflow so PR CI can be skipped when only design notes are modified.

Changes:

  • Add eng/design-notes/** to the default file patterns used to determine “only docs/notes changed”.

.github/*.md
docs/**/*.md
docs/*.md
eng/design-notes/**
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eng/design-notes/** matches any file type under that directory. That could unintentionally mark a PR as “docs-only” and skip CI even if non-doc artifacts (e.g., scripts, binaries, generated outputs) are added there later. Narrow the default patterns to markdown files only (e.g., eng/design-notes/**/*.md / eng/design-notes/*.md) to keep the skip behavior scoped to design notes content.

Suggested change
eng/design-notes/**
eng/design-notes/**/*.md
eng/design-notes/*.md

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kachawla this is good suggestion

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.38%. Comparing base (2ea450a) to head (f40df2a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11567      +/-   ##
==========================================
- Coverage   51.40%   51.38%   -0.02%     
==========================================
  Files         699      699              
  Lines       44156    44156              
==========================================
- Hits        22698    22690       -8     
- Misses      19291    19295       +4     
- Partials     2167     2171       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add specs/ to the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants