fix(install): guard directory enumeration so -WhatIf no longer throws - #24
Merged
Merged
Conversation
raandree
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install-CopilotAtelier -WhatIfaborted with a terminatingItemNotFoundException("Cannot find path '...\CopilotAtelier' because it doesnot exist"). The legacy-directory sweep enumerated the canonical target
unconditionally, but under
-WhatIfthe target tree is never created(
New-Item/Copy-ItemhonourShouldProcessand are skipped), so theenumeration hit a path that did not exist.
Fix
Run the sweep only when the target exists, matching how the rest of the function
already guards optional paths with
Test-Path.Tests
Added a regression test asserting
-WhatIfneither throws nor creates thecanonical target. Full
Install-CopilotAteliersuite: 26 passed, 0 failed.Fixes #23