Replace pkg_resources to importlib.resources #136
Open
oatsu-gh wants to merge 8 commits into
Open
Conversation
**Note this change make it unavailable on python<3.9.** - Use `importlib.resources` instead of `pkg_resources`. - In `example_label_file`, the argument `phone_level` must be assigned using a keyword name.
python3.2 以降で `assertRaisesRegexp` -> `assertRaisesRegex` に変更されているため修正。
Owner
|
Thank you! Can you update github actions settings to drop python 3.9 and add 3.12 instead? |
Author
|
Thank you for checking!
Sure, I'll try that.
|
Owner
|
looks like lint is failing. can you fix it? I'll triger CI again later |
Author
|
OK, checking now |
Author
|
Fixed import sort, to fix the isort linting error. |
Owner
|
https://github.com/r9y9/nnmnkwii/actions/runs/17978488176/job/51140647384?pr=136 looks like CI still complains about linting issues |
windows python312 を削除 (pysen のうち flake8 がうまく動かない模様)
- Fixed error `TypeError: 'nnmnkwii.util.files' is not a package`
Author
|
On python312, This pysen's error is expected to be come from the flake8 incompatibility. I have no good ideas for now. Error log of |
Author
|
Newer pysen and flake8>=6.1.0 might solve these problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #135
pkg_resourcestoimportlib.resources, in order to use nnmnkwii even after 2025-11-30 with the latest setuptools>=81.importlib.resources.filesis available only in Python>=3.9.assertRaisesRegexp->assertRaisesRegex