feat: fix types warning errors when importing from cypress component …#12
Open
cuongld2 wants to merge 1 commit intoqwikifiers:mainfrom
Open
feat: fix types warning errors when importing from cypress component …#12cuongld2 wants to merge 1 commit intoqwikifiers:mainfrom
cuongld2 wants to merge 1 commit intoqwikifiers:mainfrom
Conversation
Author
|
@shairez @jordanpowell88 if you guys can have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tests
What is it?
Description
The key fix: The mount function now accepts JSXOutput | JSXNode[] | FunctionComponent instead of just JSXNode, matching Qwik's render() function signature. This eliminates TypeScript errors when using syntax in tests.
Use cases and why
Screenshots/Demo
Before the fix
The syntax error is now gone

Checklist: