Open
Conversation
Contributor
|
Thanks for this, sorry for the very slow response. Although I think this is useful functionality I'm not sure it should be pushed into the core Gen interface, I think it would make more sense as a utility that could be passed a Gen. |
Contributor
Author
|
Thanks for the reply! No worries at all. Not opposed to moving it to an external/static interface. My only counter is that it adds extra characters to lines which can already be long (but static imports can resolve that). For some reference to other libraries, Scalacheck and Hypothesis both define functions (sample/example) on their equivalent Gen interface. EQC has it in the Gen module but Erlang is a harder comparison because there are only module functions: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to get or print samples from a generator. The visibility changes made to support this I believe to be safe because:
BoundarySkewedDistributionshouldn't have negative consequences and can be helpful for debugging