fix(website/listing): resolve category links to nearest parent listing#14495
Open
mcanouil wants to merge 1 commit intoquarto-dev:mainfrom
Open
fix(website/listing): resolve category links to nearest parent listing#14495mcanouil wants to merge 1 commit intoquarto-dev:mainfrom
mcanouil wants to merge 1 commit intoquarto-dev:mainfrom
Conversation
When a post is included in multiple listings (for example a homepage that lists everything plus a blog listing under `blog/`), the category badges on the post page wired to the wrong listing href. The previous prefix walk in `findNearestParentListing` stripped the leading slash from the post path before comparing against listing pathnames that retained theirs, so no listing ever matched and the function returned `undefined`. The caller then fell back to `document.referrer` or `listingHrefs[0]`, neither of which tracks the post's actual position in the directory tree. Replace the walk with a longest-directory-prefix match anchored at path boundaries: each listing is reduced to its containing directory, and the deepest directory that prefixes the post's directory wins. The fallback to referrer and first listing is retained for posts that are not under any listing's directory. Closes quarto-dev#14493
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix category links on a post going to the wrong listing when the post appears in multiple listings.
findNearestParentListingis rewritten as a longest-directory-prefix match anchored at path boundaries, so the deepest listing whose directory contains the post wins instead of falling back todocument.referreror the first entry inlistingHrefs.Closes #14493