Remove deprecated LinkerScriptRule::(add|remove|update)Chunk APIs#1120
Remove deprecated LinkerScriptRule::(add|remove|update)Chunk APIs#1120Steven6798 wants to merge 2 commits intoqualcomm:mainfrom
Conversation
|
@Steven6798 please add a more descriptive commit msg |
parth-07
left a comment
parth-07
left a comment
There was a problem hiding this comment.
The change looks good to me. Can you please verify that these APIs are not used / mentioned in the plugin framework documentation?
I will look into this. Thanks for the feedback. |
parth-07
left a comment
parth-07
left a comment
There was a problem hiding this comment.
Can you please address the @quic-shaksuma review for improving the commit message? In particular, commit title should be improved. 'Removed deprecated APIs' can be made more precise by changing it to perhaps 'Remove deprecated LinkerScriptRule::(add|remove|update)Chunk APIs'
Steven6798
changed the title
parth-07
left a comment
parth-07
left a comment
There was a problem hiding this comment.
@Steven6798 Please change the commit title, instead of just changing the PR title.
Done. Thanks for the help. Let me know if I need anything else. |
Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
…move|update)Chunk APIs Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
quic-seaswara
force-pushed
the
fix-issue-532
branch
from
4744fcb to
76a6eb3
Compare
5 participants
This closes #532
According to Parth: