chore(sdk): drop stale gitattributes and gitmodules - #1251
Merged
Conversation
sdk/.gitmodules and sdk/.gitattributes came in via the GenieX-bridge squash-import and target paths that don't exist (sdk/third-party/, sdk/plugins/qnn/libs/, sdk/libs/). The root .gitattributes has a single-line 'filter=lfs' pattern of '.', which matches nothing. Signed-off-by: Mengsheng Wu <mengshengwu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three git-metadata files in the tree are dead configuration and get removed:
sdk/.gitmodules— declares submodules atsdk/third-party/jniandsdk/third-party/llama.cpp.sdk/third-party/does not exist; the active submodules (third-party/llama.cpp,third-party/geniex-qairt) are registered in the repo-root.gitmodules. Carried over by the GenieX-bridge squash-import.sdk/.gitattributes— declares LFS filters forplugins/qnn/libs/**,libs/**, and*.dll/*.lib/*.so. None of those paths exist undersdk/, and no.dll/.lib/.soare tracked insdk/. Same origin..gitattributes(repo root) — single line. filter=lfs diff=lfs merge=lfs -text. The pattern.matches nothing (git check-attr filter -- <any-source>reportsunspecified), so it has no effect.Confirmed still-active git-metadata files are untouched: repo-root
.gitmodules,sdk/patches/.gitattributes,tests/cli/.gitattributes.Test plan
git check-attr filter -- sdk/CMakeLists.txt sdk/src/device.cppreportsunspecified— nothing was silently pulled from the deleted attribute files.git submodule statuslists exactlythird-party/llama.cppandthird-party/geniex-qairt.git lfs ls-filesstill lists the threetests/cli/assets/LFS entries — thetests/cli/.gitattributespattern is unaffected.