fix: update shmbridge testcase#446
Open
vnarapar wants to merge 1 commit into
Open
Conversation
smuppand
requested changes
May 11, 2026
Contributor
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
The direction is good: this expands shmbridge from a simple qcom_scm presence/log check into stronger runtime validation for sysfs, DT, platform driver registration, binding, attributes, and uevent information.
A few changes are needed
smuppand
requested changes
May 13, 2026
vnarapar
force-pushed
the
shmbridge
branch
2 times, most recently
from
07c1148 to
53fe1d3
Compare
smuppand
requested changes
May 18, 2026
smuppand
requested changes
May 22, 2026
Contributor
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
A few updates are needed for the readme. Once those are taken care of, we can proceed with the merge.
| | 4 | **Driver-to-device binding** | Symlinks under `/sys/bus/platform/drivers/qcom_scm/` | Yes | | ||
| | 5 | **sysfs attribute readability** | `/sys/module/qcom_scm/parameters/*` | Yes | | ||
| | 6 | **Device uevent / modalias** | `<bound_device>/uevent` | Informational | | ||
| | 7 | **TEE / TrustZone device node** | `/dev/tee0`, `/dev/teepriv0` | Informational | |
Contributor
There was a problem hiding this comment.
The bold marker is not closed, and /dev/tee0, /dev/teepriv0, CONFIG_TEE should be code-formatted.
Contributor
Author
There was a problem hiding this comment.
There is ** added in the right? Can you please tell what needs to be updated?
This test validates the presence, registration, and correct runtime state of the qcom_scm driver on the target device Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>
Contributor
|
@vnarapar Could you update the commit message to include the reason for these changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test validates the presence, registration, and correct runtime state of the qcom_scm driver on the target device