[7208][FIX] stock_valuation_layer_reporting: exclude archived products - #158
Closed
nobuQuartile wants to merge 1 commit into
Closed
nobuQuartile wants to merge 1 commit into
nobuQuartile wants to merge 1 commit into
Conversation
Relational traversal in a domain (e.g. product_id.categ_id) is evaluated with active_test disabled, so SVL records of archived products were reported. Filter them out explicitly, as inventory_reporting already does.
Contributor
Author
|
At first, I will check whether we need to fix this or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QT7208
Archived products were showing up in the v2 SVL report, so they are now excluded.
Relational traversal in a domain (e.g.
product_id.categ_id) is evaluated withactive_test=False, so SVL records of archived products were included unlessproduct_id.active = Trueis stated explicitly.inventory_reporting(v1) already applies the same filter; this brings v2 in line with it.get_base_domain(): applies to the storable / consumable / summary sheetsget_valuation_domain(): applies to the valuation sheet and the product category totals in the summary