fix: Redis container no longer starts unconditionally

[Copilot]

Redis was always started during magebox bootstrap regardless of whether any project required it, and orphaned containers were never cleaned up when the compose file was regenerated without Redis.

Changes

• GenerateDefaultServices: Changed unconditional else { add Redis } to else if globalCfg.DefaultServices.Redis { add Redis }. The default global config already has Redis: true, so fresh installs are unaffected.

• DockerController.Up(): Added --remove-orphans to docker compose up -d. Containers removed from the compose file (e.g. Redis when no project needs it) are now stopped on the next up.

• Tests: Added coverage for GenerateDefaultServices with Redis enabled/disabled/Valkey, and GenerateGlobalServices with no projects requiring Redis.

Before / After

// Before — Redis always started unless Valkey was set
if globalCfg.DefaultServices.Valkey {
    compose.Services["valkey"] = g.getValkeyService()
} else {
    compose.Services["redis"] = g.getRedisService() // unconditional
}

// After — respects the Redis flag
if globalCfg.DefaultServices.Valkey {
    compose.Services["valkey"] = g.getValkeyService()
} else if globalCfg.DefaultServices.Redis {
    compose.Services["redis"] = g.getRedisService()
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• github.com (HTTP Only)
  • Triggering command: /usr/bin/ssh /usr/bin/ssh -o SendEnv=GIT_PROTOCOL git@github.com git-upload-pack 'org/repo.git' (packet block)
• nonexistent.invalid.host
  • Triggering command: /tmp/go-build2498265114/b374/teamserver.test /tmp/go-build2498265114/b374/teamserver.test -test.testlogfile=/tmp/go-build2498265114/b374/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[github-actions]

📦 PR build artifacts

• magebox-darwin-amd64
• magebox-darwin-arm64
• magebox-linux-amd64
• magebox-linux-arm64

Built from bfa74ca — view run. Artifacts expire in 14 days.

Note: artifact download links require being signed in to GitHub with access to this repository.