Enforce mysql-client as a required dependency for magerun2 support#114
Draft
Copilot wants to merge 3 commits into
Draft
Enforce mysql-client as a required dependency for magerun2 support#114Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/qoliber/magebox/sessions/953eb73d-b1d9-4663-9a40-8987e209d72a Co-authored-by: peterjaap <431360+peterjaap@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add mysql-client as a required dependency for magerun2
Enforce mysql-client as a required dependency for magerun2 support
May 12, 2026
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| // Re-check after installation | ||
| nginxInstalled = p.IsNginxInstalled() | ||
| mkcertInstalled = platform.CommandExists("mkcert") | ||
| mysqlClientInstalled = platform.CommandExists("mysqldump") |
* main: Upload PR build binaries as artifacts and comment links Release v1.17.0 Start only this project's services on magebox start Ensure installation directory exists before installation (#113)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
magerun2 database commands (
db:info,db:dump, etc.) requiremysql/mysqldumpon PATH, but MageBox never checked for or installedmysql-client, causing silent failures.Changes
Dependency detection
MysqlClientInstallCommand()toPlatformwith per-distro install commands (Homebrew/apt/dnf/pacman)Installer interface & implementations
InstallMysqlClient()to theInstallerinterface and implemented across all platforms:brew install mysql-clientdefault-mysql-clientcommunity-mysqlmariadb-clientsmagebox bootstrap(Step 1)mysqldumpon PATH alongside Docker/Nginx/mkcertmysql-clientin the missing-deps prompt and auto-installs with user consentmysql-clientis a keg-only Homebrew formula:magebox checkmysql-clientcheck in the magerun2 section that reportsmysqldumpavailability and surfaces the install command on failure:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
github.com (HTTP Only)/usr/bin/ssh /usr/bin/ssh -o SendEnv=GIT_PROTOCOL git@github.com git-upload-pack 'org/repo.git'(packet block)nonexistent.invalid.host/tmp/go-build2023940910/b374/teamserver.test /tmp/go-build2023940910/b374/teamserver.test -test.testlogfile=/tmp/go-build2023940910/b374/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)If you need me to access, download, or install something from one of these locations, you can either: