Improve benchmark-queries command with new features and refactoring#269
Open
tanmay-9 wants to merge 1 commit intoqlever-dev:mainfrom
Open
Improve benchmark-queries command with new features and refactoring#269tanmay-9 wants to merge 1 commit intoqlever-dev:mainfrom
benchmark-queries command with new features and refactoring#269tanmay-9 wants to merge 1 commit intoqlever-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BenchmarkQueriesCommandclass to module-level functionspretty_printed_queryfunction.benchmark_nameandbenchmark_descriptionto benchmark result YML file (Priority: CLI args > YAML fields > dataset name fallback)max_timeparameter torun_curl_commandinutil.pyto support server hang detection via curl's--max-timeflag--restart-on-hangoption to automatically stop and restart the server when it gets stuck during benchmarking. Additionally, track and reportserver_restartedstatus per querycompute_index_stats()to include index time and size in benchmark outputargsand fix code styling issues