use vertices_per_side argument rather than frequency which is deprecated

[jensdebruijn]

get_polygon_to_contain used the deprecated frequency argument:

The get_polygon_to_contain function and call to get_edge_bbox_in_projection_coordinates:

pyresample/pyresample/slicer.py

Line 173 in 60e6132

x, y = self.area_to_contain.get_edge_bbox_in_projection_coordinates(frequency=10)

And the "PendingDeprecationWarning" in get_edge_bbox_in_projection_coordinates:

pyresample/pyresample/geometry.py

Line 1681 in 60e6132

warnings.warn("The `frequency` argument is pending deprecation, use `vertices_per_side` instead",

• Closes get_polygon_to_contain uses the deprecated frequency argument #711
• Tests passed

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.67%. Comparing base (4da28b0) to head (7ef8821).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          89       89           
  Lines       13621    13656   +35     
=======================================
+ Hits        12759    12792   +33     
- Misses        862      864    +2     

Flag	Coverage Δ
unittests	93.67% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jensdebruijn]

Found a few more instances of the same issue. Also fixed now.

[djhoese]

If I remember correctly @mraspaud made the original switch to the newer vertices_per_side kwarg. @mraspaud could you verify that the changes made here make sense? Do you have any memory why they weren't changed when vertices_per_side was added originally?

[mraspaud]

IIRC, a frequency=10 meant a vertex every 10 pixels, so just using 10 for vertices_per_sides will probably yield different results...

[jensdebruijn]

I did check the functions and vertices_per_sides and frequency are interpreted identically in the called functions (here and here). So as far as I understand, this change wouldn't change behaviour at all, only stop the warning.

My knowledge of pyresample is quite limited, but what I understand from your comment is that perhaps they should be interpreted differently?

[mraspaud]

Indeed, my bad, thanks for pointing me to the implementation!
I don't think they need to be interpreted differently, the new name is actually clearing a confusion.

[mraspaud]

LGTM! Thanks for reducing the warning count!