Skip to content

Fix test failure with PROJ 9.8.0.#710

Merged
djhoese merged 1 commit intopytroll:mainfrom
sebastic:proj-9.8.0
Mar 6, 2026
Merged

Fix test failure with PROJ 9.8.0.#710
djhoese merged 1 commit intopytroll:mainfrom
sebastic:proj-9.8.0

Conversation

@sebastic
Copy link
Contributor

@sebastic sebastic commented Mar 6, 2026

Fixes test failures with PROJ 9.8.0 by allowing both descriptions:

=================================== FAILURES ===================================
______________ TestAreaDefinition.test_from_epsg[AreaDefinition] _______________

self = <pyresample.test.test_geometry.test_area.TestAreaDefinition object at 0x7fb1f1246580>
area_class = <class 'pyresample.future.geometry.area.AreaDefinition'>

    def test_from_epsg(self, area_class):
        """Test the from_epsg class method."""
        sweref = area_class.from_epsg('3006', 2000)
>       assert sweref.description == 'SWEREF99 TM'
E       AssertionError: assert 'ETRS89-SWE [SWEREF 99 TM]' == 'SWEREF99 TM'
E         
E         - SWEREF99 TM
E         + ETRS89-SWE [SWEREF 99 TM]

pyresample/test/test_geometry/test_area.py:1091: AssertionError
------------------------------ Captured log call -------------------------------
WARNING  pyresample.area_config:area_config.py:767 shape found from radius and resolution does not contain only integers: (793.915117526711, 452.20830661668975)
Rounding shape to (794, 453) and resolution from (2000.0, 2000.0) meters to (1996.5046649743479, 1999.7861902436046) meters
___________ TestAreaDefinition.test_from_epsg[LegacyAreaDefinition] ____________

self = <pyresample.test.test_geometry.test_area.TestAreaDefinition object at 0x7fb1f12464e0>
area_class = <class 'pyresample.geometry.AreaDefinition'>

    def test_from_epsg(self, area_class):
        """Test the from_epsg class method."""
        sweref = area_class.from_epsg('3006', 2000)
>       assert sweref.description == 'SWEREF99 TM'
E       AssertionError: assert 'ETRS89-SWE [SWEREF 99 TM]' == 'SWEREF99 TM'
E         
E         - SWEREF99 TM
E         + ETRS89-SWE [SWEREF 99 TM]

pyresample/test/test_geometry/test_area.py:1091: AssertionError
------------------------------ Captured log call -------------------------------
  • Tests passed

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.67%. Comparing base (4da28b0) to head (4ce9911).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          89       89           
  Lines       13621    13621           
=======================================
  Hits        12759    12759           
  Misses        862      862           
Flag Coverage Δ
unittests 93.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhoese djhoese added the bug label Mar 6, 2026
@djhoese djhoese self-assigned this Mar 6, 2026
@djhoese djhoese merged commit 762aece into pytroll:main Mar 6, 2026
26 checks passed
@sebastic sebastic deleted the proj-9.8.0 branch March 6, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants